Inconsistent MusicBrainz import due to parallelism

Description

After changes for five tests fail.

Environment

None

Test file(s)

None

Activity

Show:
Fabrizio Giudici
April 8, 2021, 7:56 PM
Edited

As part of a refactoring, the sorting has been inserted. The test set

expected-metadata-musicbrainz-iTunes-fg-20161210-1

has been updated to version 20210408_2135.

Fabrizio Giudici
April 8, 2021, 7:54 PM

Much likely is a race condition that didn’t trigger before. The five records are substantially equal, so the rules for picking a primary one fail; and the fallback rule is to pick the one with the first MusicBrainz UUID in lexicographic order. But a FIXME in the code points out that there is no sorting.

Fabrizio Giudici
April 8, 2021, 7:52 PM

The tests are related to MusicBrainz multiple entries for five records. The importer has some rules to decide what is considered the “main” entry, while others are labeled as ‘alternatePickOf’. The choice is different now, hence the failed tests.

Fixed

Assignee

Fabrizio Giudici

Reporter

Fabrizio Giudici